[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/slpc: Start SLPC before GuC submission on reset
Patchwork
patchwork at emeril.freedesktop.org
Wed Jun 28 00:19:48 UTC 2023
== Series Details ==
Series: drm/xe/slpc: Start SLPC before GuC submission on reset
URL : https://patchwork.freedesktop.org/series/119953/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 696bbc36794a659071dcbd39c96d05f5f8778e73
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date: Tue Jun 27 17:16:42 2023 -0700
drm/xe/slpc: Start SLPC before GuC submission on reset
The SLPC code has a strict 5ms timeout from when the start command is
queued to when we expect the reply to appear in memory. This works if
the CT channel is empty, but if the channel is busy there might be an
extra delay that causes the process to exceeded the timeout. We see
this issue when a reset occurs while userspace keeps submitting,
because the submission code is re-enabled first and it will start using
the channel to service those submissions.
To fix this, we can simply start SLPC before re-enabling submission.
This has also the benefit of not allowing submissions to go through with
an uninitialized SLPC.
Reference: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/375
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch abdb420db479bae28a2abd7ba2c66229b7e8cb77 drm-intel
696bbc367 drm/xe/slpc: Start SLPC before GuC submission on reset
-:17: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Reference:', use 'Link:' instead
#17:
Reference: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/375
-:38: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#38: FILE: drivers/gpu/drm/xe/xe_guc.c:808:
+ return xe_guc_submit_start(guc);;
total: 0 errors, 2 warnings, 0 checks, 15 lines checked
More information about the Intel-xe
mailing list