[Intel-xe] [PATCH V4 2/3] drm/xe: Add GTs under respective tile sysfs

[Upadhyay, Tejas]

> -----Original Message-----
> From: De Marchi, Lucas <lucas.demarchi at intel.com>
> Sent: Tuesday, June 27, 2023 11:08 PM
> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> Cc: intel-xe at lists.freedesktop.org
> Subject: Re: [Intel-xe] [PATCH V4 2/3] drm/xe: Add GTs under respective tile
> sysfs
> 
> On Thu, Jun 22, 2023 at 12:58:17PM +0530, Tejas Upadhyay wrote:
> >With the separation of xe_tile and xe_gt, We now consider a PCI device
> >(xe_device) to contain one or more tiles (struct xe_tile).
> >Each tile will contain one or more GTs (struct xe_gt).
> >So lets align sysfs paths accordingly.
> >
> >TODO: Currently we have gt0 under tile0 and gt1 under tile1 on
> >multi-tile. This GT indexing still under discussion, when it is
> >concluded we need to revisit this change.
> 
> do we want to merge this commit with this TODO? Once we export things to
> userspace it's always harder to change it. When you say multi-tile, are you
> referring to devices like PVC (real multi-tile) or like MTL (multi-gt)?

Current xe driver with https://patchwork.freedesktop.org/series/117614/ series already running with these questions intact. Multi-tile by I mean real multi-tile (PVC). So whenever indexing fixes everywhere if applicable changes will come. So for now I think it should be ok to merge. We already have IGT implemented and reviewed https://patchwork.freedesktop.org/series/119801/#rev3, waiting for merge for respective change.

Thanks,
Tejas
> 
> Also we had a discussion in the past, but I don't see any current discussion
> about it being taking care of. Where is the discussion you're talking about?
> 
> Lucas De Marchi
> 
> >
> >Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
> >Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> >---
> > drivers/gpu/drm/xe/xe_gt_sysfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/xe/xe_gt_sysfs.c
> >b/drivers/gpu/drm/xe/xe_gt_sysfs.c
> >index c01cc689058c..13570987a756 100644
> >--- a/drivers/gpu/drm/xe/xe_gt_sysfs.c
> >+++ b/drivers/gpu/drm/xe/xe_gt_sysfs.c
> >@@ -31,7 +31,7 @@ static void gt_sysfs_fini(struct drm_device *drm,
> >void *arg)
> >
> > int xe_gt_sysfs_init(struct xe_gt *gt)  {
> >-	struct device *dev = gt_to_xe(gt)->drm.dev;
> >+	struct xe_tile *tile = gt_to_tile(gt);
> > 	struct kobj_gt *kg;
> > 	int err;
> >
> >@@ -42,7 +42,7 @@ int xe_gt_sysfs_init(struct xe_gt *gt)
> > 	kobject_init(&kg->base, &xe_gt_sysfs_kobj_type);
> > 	kg->gt = gt;
> >
> >-	err = kobject_add(&kg->base, &dev->kobj, "gt%d", gt->info.id);
> >+	err = kobject_add(&kg->base, tile->sysfs, "gt%d", gt->info.id);
> > 	if (err) {
> > 		kobject_put(&kg->base);
> > 		return err;
> >--
> >2.25.1
> >