[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: handle TLB invalidations from CT fast-path (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Jun 30 17:41:46 UTC 2023


== Series Details ==

Series: drm/xe: handle TLB invalidations from CT fast-path (rev2)
URL   : https://patchwork.freedesktop.org/series/120074/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit edcca6078211f7fdde568c9f377f448f81d4c4d1
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Fri Jun 30 18:14:59 2023 +0100

    drm/xe: handle TLB invalidations from CT fast-path
    
    In various test cases that put the system under a heavy load, we can
    sometimes see errors with missed TLB invalidations. In such cases we see
    the interrupt arrive for the invalidation from the GuC, however the
    actual processing of the completion is pushed onto a workqueue and
    handled with all the other CT stuff, which might take longer than
    expected. Since we expect TLB invalidations to complete within a
    reasonable amount of time (at most ~250ms), and they do seem pretty
    critical, allow handling directly from the CT fast-path.
    
    v2 (José):
      - Actually use the correct spinlock/unlock_irq, since pending_lock is
        grabbed from IRQ.
    
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/297
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/320
    References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/449
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
    Cc: José Roberto de Souza <jose.souza at intel.com>
+ /mt/dim checkpatch 3b458784c9645681eea7611e571e1ee752bb2bc0 drm-intel
edcca6078 drm/xe: handle TLB invalidations from CT fast-path
-:22: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' instead
#22: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/297

-:23: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' instead
#23: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/320

-:24: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' instead
#24: 
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/449

total: 0 errors, 3 warnings, 0 checks, 172 lines checked




More information about the Intel-xe mailing list