[Intel-xe] [PATCH 2/4] drm/xe/guc: Return the lower part of blocking H2G message
Matthew Brost
matthew.brost at intel.com
Tue Mar 28 21:09:18 UTC 2023
The upper layers may need this data, an example of this is allocating
DIST doorbell.
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.c | 6 +++++-
drivers/gpu/drm/xe/xe_guc_pc.c | 6 ++++--
drivers/gpu/drm/xe/xe_huc.c | 2 +-
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index e5ed9022a0a2..54578a21da47 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -26,6 +26,7 @@ struct g2h_fence {
wait_queue_head_t wq;
u32 *response_buffer;
u32 seqno;
+ u32 status;
u16 response_len;
u16 error;
u16 hint;
@@ -728,7 +729,7 @@ static int guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
ret = -EIO;
}
- return ret > 0 ? 0 : ret;
+ return ret > 0 ? g2h_fence.status : ret;
}
int xe_guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
@@ -794,6 +795,9 @@ static int parse_g2h_response(struct xe_guc_ct *ct, u32 *msg, u32 len)
g2h_fence->response_len = response_len;
memcpy(g2h_fence->response_buffer, msg + GUC_CTB_MSG_MIN_LEN,
response_len * sizeof(u32));
+ } else {
+ g2h_fence->status =
+ FIELD_GET(GUC_HXG_RESPONSE_MSG_0_DATA0, msg[1]);
}
g2h_release_space(ct, GUC_CTB_HXG_MSG_MAX_LEN);
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index 5a8d827ba770..df080588dd02 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -204,11 +204,13 @@ static int pc_action_query_task_state(struct xe_guc_pc *pc)
/* Blocking here to ensure the results are ready before reading them */
ret = xe_guc_ct_send_block(ct, action, ARRAY_SIZE(action));
- if (ret)
+ if (ret < 0) {
drm_err(&pc_to_xe(pc)->drm,
"GuC PC query task state failed: %pe", ERR_PTR(ret));
+ return ret;
+ }
- return ret;
+ return 0;
}
static int pc_action_set_param(struct xe_guc_pc *pc, u8 id, u32 value)
diff --git a/drivers/gpu/drm/xe/xe_huc.c b/drivers/gpu/drm/xe/xe_huc.c
index a9448c6f6418..2203d281853a 100644
--- a/drivers/gpu/drm/xe/xe_huc.c
+++ b/drivers/gpu/drm/xe/xe_huc.c
@@ -39,7 +39,7 @@ int xe_huc_init(struct xe_huc *huc)
huc->fw.type = XE_UC_FW_TYPE_HUC;
ret = xe_uc_fw_init(&huc->fw);
- if (ret)
+ if (ret < 0)
goto out;
xe_uc_fw_change_status(&huc->fw, XE_UC_FIRMWARE_LOADABLE);
--
2.34.1
More information about the Intel-xe
mailing list