[Intel-xe] [PATCH] drm/xe: Replace DRM_ERROR() with drm_err()

Gustavo Sousa gustavo.sousa at intel.com
Mon May 29 15:16:40 UTC 2023


Quoting Gustavo Sousa (2023-05-29 12:08:31-03:00)
>DRM_ERROR() has been deprecated in favor of pr_err(). However, we should
>prefer to use drm_err() whenever possible so we get device-specific
>output with the error message.
>
>Adding an "xe" member to struct xe_reg_sr does not seem very
>justifiable, since the only as of now is to register a clean up function
>and, with this change, print error messages. So let's just add a
>parameter to xe_reg_sr_add().
>
>v2:
>  - Prefer drm_err() over pr_err(). (Matt, Jani)

This is a v2, with a different subject, of [1].

[1] https://patchwork.freedesktop.org/patch/539584/?series=118402&rev=1

--
Gustavo Sousa


More information about the Intel-xe mailing list