[Intel-xe] [PATCH 06/10] drm/xe/oa: Start implementing OA stream open ioctl

Dixit, Ashutosh ashutosh.dixit at intel.com
Fri Sep 8 04:38:53 UTC 2023


On Wed, 23 Aug 2023 12:55:09 -0700, Nerlige Ramappa, Umesh wrote:
>

Hi Umesh,

> On Mon, Aug 07, 2023 at 06:31:55PM -0700, Ashutosh Dixit wrote:
> >+/*
> >+ * OA timestamp frequency = CS timestamp frequency in most platforms. On some
> >+ * platforms OA unit ignores the CTC_SHIFT and the 2 timestamps differ. In such
> >+ * cases, return the adjusted CS timestamp frequency to the user.
> >+ */
> >+u32 xe_oa_timestamp_frequency(struct xe_device *xe)
>
> This should ideally be dependent on OA buffer, but the i915 interface
> did not have a way to pass that. We should do that in XE.

By "dependent on OA buffer" you mean per gt? I have added a new patch
making xe_oa_timestamp_frequency per gt so that the changes can be reviewed
easily, if needed we can squash the new patch with this one.

https://patchwork.freedesktop.org/patch/556307/?series=121084&rev=5

Please review.

Thanks.
--
Ashutosh


More information about the Intel-xe mailing list