[Intel-xe] [PATCH 09/10] drm/xe/oa: Read file_operation

[Dixit, Ashutosh]

On Wed, 23 Aug 2023 12:46:45 -0700, Nerlige Ramappa, Umesh wrote:
>

Hi Umesh,

> On Mon, Aug 07, 2023 at 06:31:58PM -0700, Ashutosh Dixit wrote:
> >+static bool oa_report_ctx_invalid(struct xe_oa_stream *stream, void
> >*report)
> >+{
> >+	return false;
> >+}
>
> I think I had posted an updated patch for i915. The context valid bit is
> applicable to gen12 as well, so we should implement the context id
> valid/invalid helper.

Couldn't find your patch but I have implmented it in patch v2. Please
review.

https://patchwork.freedesktop.org/patch/556313/?series=121084&rev=5

> >+	/* An out of bounds or misaligned head or tail pointer implies a driver bug */
> >+	if (drm_WARN_ONCE(&stream->oa->xe->drm,
> >+			  head > OA_BUFFER_SIZE || tail > OA_BUFFER_SIZE,
> >+			  "Inconsistent OA buffer pointers: head = %u, tail = %u\n",
> >+			  head, tail))
> >+		return -EIO;
> >+
> >+	for (/* none */; OA_TAKEN(tail, head); head = (head + report_size) & mask) {
>
> We can drop the 'none' comment.

Done.

Thanks.
--
Ashutosh