[PATCH] drm/xe/guc: Fix typos in VF CFG KLVs descriptions

Piotr Piórkowski piotr.piorkowski at intel.com
Thu Apr 25 14:21:30 UTC 2024


Piotr Piórkowski <piotr.piorkowski at intel.com> wrote on śro [2024-kwi-24 21:00:05 +0200]:
> Michal Wajdeczko <michal.wajdeczko at intel.com> wrote on śro [2024-kwi-24 16:05:06 +0200]:
> > Apart from the obvious spelling typo, use the correct values for
> > infinity quantum/timeout settings (it's 0x0 instead of 0xFFFFFFFF).
> > 
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Piotr Piórkowski <piotr.piorkowski at intel.com>
> > ---
> >  drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/abi/guc_klvs_abi.h b/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
> > index e53ffaee2fcd..5c1d40432ca0 100644
> > --- a/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
> > +++ b/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
> > @@ -194,9 +194,9 @@ enum  {
> >   *      granularity) since the GPUs clock time runs off a different crystal
> >   *      from the CPUs clock. Changing this KLV on a VF that is currently
> >   *      running a context wont take effect until a new context is scheduled in.
> > - *      That said, when the PF is changing this value from 0xFFFFFFFF to
> > - *      something else, it might never take effect if the VF is running an
> > - *      inifinitely long compute or shader kernel. In such a scenario, the
> > + *      That said, when the PF is changing this value from 0x0 to
> > + *      a non-zero value, it might never take effect if the VF is running an
> > + *      infinitely long compute or shader kernel. In such a scenario, the
> >   *      PF would need to trigger a VM PAUSE and then change the KLV to force
> >   *      it to take effect. Such cases might typically happen on a 1PF+1VF
> >   *      Virtualization config enabled for heavier workloads like AI/ML.
> > @@ -215,9 +215,9 @@ enum  {
> >   *      different crystal from the CPUs clock. Changing this KLV on a VF
> >   *      that is currently running a context wont take effect until a new
> >   *      context is scheduled in.
> > - *      That said, when the PF is changing this value from 0xFFFFFFFF to
> > - *      something else, it might never take effect if the VF is running an
> > - *      inifinitely long compute or shader kernel.
> > + *      That said, when the PF is changing this value from 0x0 to
> > + *      a non-zero value, it might never take effect if the VF is running an
> > + *      infinitely long compute or shader kernel.
> >   *      In this case, the PF would need to trigger a VM PAUSE and then change
> >   *      the KLV to force it to take effect. Such cases might typically happen
> >   *      on a 1PF+1VF Virtualization config enabled for heavier workloads like
> 
> Acked-by: Piotr Piórkowski <piotr.piorkowski at intel.com>
If my previous A-B was not enough:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski at intel.com>

> 
> > -- 
> > 2.43.0
> > 
> 
> -- 

-- 


More information about the Intel-xe mailing list