[PATCH] drm/xe: avoid using 'grouped targets' in Makefile

Lucas De Marchi lucas.demarchi at intel.com
Tue Feb 20 05:44:57 UTC 2024


On Mon, Feb 19, 2024 at 03:58:45PM +0200, Dafna Hirschfeld wrote:
>The feature 'grouped target' ('&:') in makefiles is only added in 'make'
>version 4.3. This cause problems in older version of 'make'.
>(Specifically $(@D) is wrongly interpreted - it creates 'generated' dir
>in the source path instead of the build path).
>Avoid this feature.

but it was used for a reason since a single invocation is supposed to
generate both the .c and .h from a single invocation. AFAIR when
implementing this, not using grouped target would be a mix and match on
having a succesfull build. Does removing it really work with incremental
and parallel build?

Lucas De Marchi


More information about the Intel-xe mailing list