[PATCH] drm/xe: avoid using 'grouped targets' in Makefile

[Dafna Hirschfeld]

On 19.02.2024 23:44, Lucas De Marchi wrote:
>On Mon, Feb 19, 2024 at 03:58:45PM +0200, Dafna Hirschfeld wrote:
>>The feature 'grouped target' ('&:') in makefiles is only added in 'make'
>>version 4.3. This cause problems in older version of 'make'.
>>(Specifically $(@D) is wrongly interpreted - it creates 'generated' dir
>>in the source path instead of the build path).
>>Avoid this feature.
>
>but it was used for a reason since a single invocation is supposed to
>generate both the .c and .h from a single invocation. AFAIR when
>implementing this, not using grouped target would be a mix and match on
>having a succesfull build. Does removing it really work with incremental
>and parallel build?

Hi, we had a compilation issue, where the wrong version of the generated header
(xe_wa_oob.h) is included from the source directory instead of the build
directory. I thought the problem is due to the feature '&:' which is not
there for our 'make' (v4.2). But this didn't fix the issue. I was able to fix
the issue with that patch:
https://lore.kernel.org/intel-xe/20240220090003.1523866-1-dhirschfeld@habana.ai/T/#u

Thanks,
Dafna

>
>Lucas De Marchi