[PATCH] drm/xe: Use pointers in trace events

Lucas De Marchi lucas.demarchi at intel.com
Thu Feb 22 22:25:17 UTC 2024


On Thu, Feb 22, 2024 at 05:12:11PM +0100, Thomas Hellström wrote:
>On Thu, 2024-02-22 at 06:41 -0800, Lucas De Marchi wrote:
>> Commit a0df2cc858c3 ("drm/xe/xe_bo_move: Enhance xe_bo_move trace")
>> inadvertently reverted commit 8d038f49c1f3 ("drm/xe: Fix cast on
>> trace
>> variable"), breaking the build on 32bits.
>>
>> As noted by Ville, there's no point in converting the pointers to u64
>> and add casts everywhere. In fact, it's better to just use %p and let
>> the address be hashed. Convert all the cases in xe_trace.h to use
>> pointers.
>>
>> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> Cc: Matt Roper <matthew.d.roper at intel.com>
>> Cc: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
>> Cc: Oak Zeng <oak.zeng at intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
>Reviewed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>

normally I'd leave it on the the mailing list a little bit more for
people involved in previous discussion to chime in. However this is
blocking the pull request to 6.9, so I'm applying it.

thanks
Lucas De Marchi


More information about the Intel-xe mailing list