[CI] drm/xe/guc: Remove spurious line feed in debug print

[Michal Wajdeczko]

On 26.06.2024 22:35, Souza, Jose wrote:
> On Wed, 2024-06-26 at 22:12 +0200, Michal Wajdeczko wrote:
>> From: John Harrison <John.C.Harrison at Intel.com>
>>
>> Including line feeds at the start of a debug print messes up the
>> output when sent to dmesg. The break actually appears between all the
>> usefu prefix information and the actual string being printed. In this
>> case, each block of data has a very clear start line and an extra
>> delimeter is really not necessary. So don't do it.
> 
> I guess the indention was to have one blank like between guc_ctb_snapshot_print() 'cmd[X]' lines and 'G2H CTB (all sizes in DW):'.
> I agree with the change if you add one line breaker in the end of guc_ctb_snapshot_print().

but 'cmd[XXX]' lines already have additional indent compared to 'H2G|G2H
CTB' headers so IMO this extra separation line seems unnecessary:

[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0: TLB invalidation time'd out,
seqno=27, recv=26
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0: H2G CTB (all sizes in DW):
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      size: 1024
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      resv_space: 0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      head: 0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      tail: 572
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      space: 451
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      broken: 0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      head (memory): 568
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      tail (memory): 572
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      status (memory): 0x0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      cmd[568]: 0x80670003
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      cmd[569]: 0x20007000
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      cmd[570]: 0x0000001b
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      cmd[571]: 0x80000003
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0: G2H CTB (all sizes in DW):
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      size: 4096
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      resv_space: 1024
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      head: 210
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      tail: 0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      space: 3068
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      broken: 0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      head (memory): 210
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      tail (memory): 210
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      status (memory): 0x0
[ ] xe 0000:4d:00.1: [drm] *ERROR* GT0:      g2h outstanding: 1

and IMO printing empty lines is just a waste of paper ;)

> 
>>
>> Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
>> Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> ---
>> cherry-picked from [1]
>>
>> [1] https://patchwork.freedesktop.org/patch/598024/?series=134695&rev=2
>> ---
>>  drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
>> index 873d1bcbedd7..113e6348c6ac 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
>> @@ -1489,7 +1489,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
>>  		drm_puts(p, "H2G CTB (all sizes in DW):\n");
>>  		guc_ctb_snapshot_print(&snapshot->h2g, p);
>>  
>> -		drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
>> +		drm_puts(p, "G2H CTB (all sizes in DW):\n");
>>  		guc_ctb_snapshot_print(&snapshot->g2h, p);
>>  
>>  		drm_printf(p, "\tg2h outstanding: %d\n",
>