[PATCH v4] drm/xe: remove unused LE_COS

[Lin, Shuicheng]

On Wed, April 2, 2025 9:44 PM Upadhyay, Tejas wrote:
> > -----Original Message-----
> > From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of
> > Shuicheng Lin
> > Sent: 03 April 2025 09:16
> > To: intel-xe at lists.freedesktop.org
> > Cc: Lin, Shuicheng <shuicheng.lin at intel.com>; Roper, Matthew D
> > <matthew.d.roper at intel.com>; De Marchi, Lucas
> > <lucas.demarchi at intel.com>
> > Subject: [PATCH v4] drm/xe: remove unused LE_COS
> >
> > value is missed for LE_COS.
> > The value for this field is universally "0" for every MOCS entry on
> > the old Xe_LP platforms, and the whole field has been removed from Xe_HP
> onward.
> > Just delete the line so that we don't have an unused definition.
> 
> Your patch says V4 but no revision history mentioned.

The change is just some typo error. So I didn't mention it. Sorry for the confusion.

Shuicheng

> 
> >
> > Suggested-by: Matt Roper <matthew.d.roper at intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> > Signed-off-by: Shuicheng Lin <shuicheng.lin at intel.com>
> > ---
> >  drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > index da1f198ac107..c1590e322ef3 100644
> > --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> > @@ -62,7 +62,6 @@
> >  #define   LE_SSE_MASK				REG_GENMASK(18,
> > 17)
> >  #define   LE_SSE(value)
> > 	REG_FIELD_PREP(LE_SSE_MASK, value)
> >  #define   LE_COS_MASK				REG_GENMASK(16,
> > 15)
> 
> Do we need LE_COS_MASK then?

Yes. It is used in the code for read.

Shuicheng

> 
> Tejas
> 
> > -#define   LE_COS(value)
> > 	REG_FIELD_PREP(LE_COS_MASK)
> >  #define   LE_SCF_MASK				REG_BIT(14)
> >  #define   LE_SCF(value)
> > 	REG_FIELD_PREP(LE_SCF_MASK, value)
> >  #define   LE_PFM_MASK				REG_GENMASK(13,
> > 11)
> > --
> > 2.25.1