[PATCH v4] drm/xe: remove unused LE_COS

[Matt Roper]

On Thu, Apr 03, 2025 at 03:46:08AM +0000, Shuicheng Lin wrote:
> value is missed for LE_COS.

I'd expand this a bit more.  Something along the lines of  "The LE_COS
definition missed passing the value parameter to REG_FIELD_PREP.  This
didn't cause build errors because the entire macro was unused."

The rest of the commit message and patch looks good.

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> The value for this field is universally "0" for every MOCS entry on
> the old Xe_LP platforms, and the whole field has been removed from
> Xe_HP onward. Just delete the line so that we don't have an unused
> definition.
> 
> Suggested-by: Matt Roper <matthew.d.roper at intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Signed-off-by: Shuicheng Lin <shuicheng.lin at intel.com>
> ---
>  drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> index da1f198ac107..c1590e322ef3 100644
> --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> @@ -62,7 +62,6 @@
>  #define   LE_SSE_MASK				REG_GENMASK(18, 17)
>  #define   LE_SSE(value)				REG_FIELD_PREP(LE_SSE_MASK, value)
>  #define   LE_COS_MASK				REG_GENMASK(16, 15)
> -#define   LE_COS(value)				REG_FIELD_PREP(LE_COS_MASK)
>  #define   LE_SCF_MASK				REG_BIT(14)
>  #define   LE_SCF(value)				REG_FIELD_PREP(LE_SCF_MASK, value)
>  #define   LE_PFM_MASK				REG_GENMASK(13, 11)
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation