[PATCH v3 1/5] drm/xe/bo: fix alignment with non-4KiB kernel page sizes
Mingcong Bai
jeffbai at aosc.io
Fri Aug 1 01:06:19 UTC 2025
Hi Simon,
在 2025/7/31 18:48, Simon Richter 写道:
> Hi,
>
> On 7/31/25 18:55, Mingcong Bai wrote:
>
>> - bo->size = size;
>> + bo->size = aligned_size;
>
>> Is actually still needed. Without this change, the kernel does not
>> start up with an Intel B580.
>
> bo->size has been removed in commit ec9223b49, though -- instead, the
> size is taken from the underlying GEM object, and the size field there
> is taken from the third parameter to drm_gem_private_object_init, which
> is "aligned_size" in your patch already, so this field is fully
> redundant even if the size has been aligned.
My mistake - sorry! We were testing with 6.16, the master source does
work without this change.
That said, this patch is still marked Cc stable, so I would recommend
either dropping that, or consider submitting a separate copy suitable
for that purpose. I might be wrong though, so please, if any reviewers
could help guide Simon (and correct me), go ahead.
Best Regards,
Mingcong Bai
> Tested on ppc64le with B580 using 64k pages, still survives a piglit run
> just fine.
>
> The field being removed was the reason for me resubmitting the patch
> stack: it stopped compiling without dropping this line.
>
> Simon
More information about the Intel-xe
mailing list