[PATCH] drm/i915/display: handle return value in intel_sdvo_enable_hotplug

[Kandpal, Suraj]

>Subject: [PATCH] drm/i915/display: handle >return value in intel_sdvo_enable_hotplug

The subject does not match what you are doing in the patch maybe fix that .
Sorry for the noise my email client seems to be acting weird.(may still not be working right so sorry again will probably be fixed by the next reply I send :D)
Other than that everything
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal at intel.com>

>
>Report in log if intel_sdvo_enable_hotplug failed
>
>Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>---
>drivers/gpu/drm/i915/display/intel_sdvo.c | 6 >++++--
>1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git >a/drivers/gpu/drm/i915/display/intel_sdvo.c >b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index 87aff2754f69..99a5ef1401a8 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -2052,8 +2052,10 @@ static void >intel_sdvo_enable_hotplug(struct intel_encoder >*encoder)
>{
>         struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
>
>-       intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
>-                            &intel_sdvo->hotplug_active, 2);
>+       if (!intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
>+                                 &intel_sdvo->hotplug_active, 2))
>+               drm_warn(intel_sdvo->base.base.dev,
>+                        "Failed to enable hotplug on SDVO encoder\n");
>}
>
>static enum intel_hotplug_state



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20250822/7008b750/attachment-0001.htm>