[PATCH v3 03/13] drm/xe: Fix xe_tile_init_noalloc() error propagation

[Upadhyay, Tejas]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas
> De Marchi
> Sent: Saturday, February 8, 2025 3:50 AM
> To: intel-xe at lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Dugast, Francois
> <francois.dugast at intel.com>; Auld, Matthew <matthew.auld at intel.com>;
> Ceraolo Spurio, Daniele <daniele.ceraolospurio at intel.com>; De Marchi, Lucas
> <lucas.demarchi at intel.com>
> Subject: [PATCH v3 03/13] drm/xe: Fix xe_tile_init_noalloc() error propagation
> 
> Propagate the error to the caller so initialization properly stops if sysfs creation
> fails.
> 
> Reviewed-by: Francois Dugast <francois.dugast at intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_tile.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c index
> 2825553b568f7..377438ea6b838 100644
> --- a/drivers/gpu/drm/xe/xe_tile.c
> +++ b/drivers/gpu/drm/xe/xe_tile.c
> @@ -172,9 +172,7 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
> 
>  	xe_wa_apply_tile_workarounds(tile);
> 
> -	err = xe_tile_sysfs_init(tile);
> -
> -	return 0;
> +	return xe_tile_sysfs_init(tile);

Is this really critical that we should fail driver probe without sysfs?

Tejas
>  }
> 
>  int xe_tile_init(struct xe_tile *tile)
> --
> 2.48.1