[PATCH v3 03/13] drm/xe: Fix xe_tile_init_noalloc() error propagation

Ghimiray, Himal Prasad himal.prasad.ghimiray at intel.com
Mon Feb 10 17:59:38 UTC 2025



On 08-02-2025 03:49, Lucas De Marchi wrote:
> Propagate the error to the caller so initialization properly stops if
> sysfs creation fails.
> 
> Reviewed-by: Francois Dugast <francois.dugast at intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>   drivers/gpu/drm/xe/xe_tile.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
> index 2825553b568f7..377438ea6b838 100644
> --- a/drivers/gpu/drm/xe/xe_tile.c
> +++ b/drivers/gpu/drm/xe/xe_tile.c
> @@ -172,9 +172,7 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
>   
>   	xe_wa_apply_tile_workarounds(tile);
>   
> -	err = xe_tile_sysfs_init(tile);
> -
> -	return 0;
> +	return xe_tile_sysfs_init(tile);

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>

>   }
>   
>   int xe_tile_init(struct xe_tile *tile)



More information about the Intel-xe mailing list