[PATCH 1/2] drm/xe: Remove pointless gen11 assertions

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas De Marchi
Sent: Thursday, March 6, 2025 2:08 PM
To: intel-xe at lists.freedesktop.org
Cc: De Marchi, Lucas <lucas.demarchi at intel.com>
Subject: [PATCH 1/2] drm/xe: Remove pointless gen11 assertions
> 
> xe driver doesn't really work in gen11. Stop asserting for >= 11,
> as it would likely explode anyway if tried on such platforms.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Aside:
There probably isn't too much harm in keeping the extra security
afforded by checking for gen11+ platforms in xe_force_wake.c,
but if we're asserting that XE shouldn't be run on gen11
anyways, then I agree that it's a bit superfluous.

LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/xe_force_wake.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
> index 4f6784e5abf88913b81a364bb393f6286d52be78..8a5cba22b58610224b854e42b9431dcae174ac1c 100644
> --- a/drivers/gpu/drm/xe/xe_force_wake.c
> +++ b/drivers/gpu/drm/xe/xe_force_wake.c
> @@ -49,9 +49,6 @@ void xe_force_wake_init_gt(struct xe_gt *gt, struct xe_force_wake *fw)
>  	fw->gt = gt;
>  	spin_lock_init(&fw->lock);
>  
> -	/* Assuming gen11+ so assert this assumption is correct */
> -	xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);
> -
>  	if (xe->info.graphics_verx100 >= 1270) {
>  		init_domain(fw, XE_FW_DOMAIN_ID_GT,
>  			    FORCEWAKE_GT,
> @@ -67,9 +64,6 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct xe_force_wake *fw)
>  {
>  	int i, j;
>  
> -	/* Assuming gen11+ so assert this assumption is correct */
> -	xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);
> -
>  	if (!xe_gt_is_media_type(gt))
>  		init_domain(fw, XE_FW_DOMAIN_ID_RENDER,
>  			    FORCEWAKE_RENDER,
> 
> -- 
> 2.48.1
>