[PATCH 1/2] drm/xe: Remove pointless gen11 assertions
Upadhyay, Tejas
tejas.upadhyay at intel.com
Fri Mar 7 12:21:29 UTC 2025
> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Lucas
> De Marchi
> Sent: Friday, March 7, 2025 3:38 AM
> To: intel-xe at lists.freedesktop.org
> Cc: De Marchi, Lucas <lucas.demarchi at intel.com>
> Subject: [PATCH 1/2] drm/xe: Remove pointless gen11 assertions
>
> xe driver doesn't really work in gen11. Stop asserting for >= 11, as it would
> likely explode anyway if tried on such platforms.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
> drivers/gpu/drm/xe/xe_force_wake.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_force_wake.c
> b/drivers/gpu/drm/xe/xe_force_wake.c
> index
> 4f6784e5abf88913b81a364bb393f6286d52be78..8a5cba22b58610224b8
> 54e42b9431dcae174ac1c 100644
> --- a/drivers/gpu/drm/xe/xe_force_wake.c
> +++ b/drivers/gpu/drm/xe/xe_force_wake.c
> @@ -49,9 +49,6 @@ void xe_force_wake_init_gt(struct xe_gt *gt, struct
> xe_force_wake *fw)
> fw->gt = gt;
> spin_lock_init(&fw->lock);
>
> - /* Assuming gen11+ so assert this assumption is correct */
> - xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);
> -
> if (xe->info.graphics_verx100 >= 1270) {
> init_domain(fw, XE_FW_DOMAIN_ID_GT,
> FORCEWAKE_GT,
> @@ -67,9 +64,6 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct
> xe_force_wake *fw) {
> int i, j;
>
> - /* Assuming gen11+ so assert this assumption is correct */
> - xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);
> -
Yes looks useless, LGTM,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
Tejas
> if (!xe_gt_is_media_type(gt))
> init_domain(fw, XE_FW_DOMAIN_ID_RENDER,
> FORCEWAKE_RENDER,
>
> --
> 2.48.1
More information about the Intel-xe
mailing list