[PATCH v2] drm/xe/hwmon: expose fan speed
Raag Jadav
raag.jadav at intel.com
Fri Mar 7 17:58:20 UTC 2025
On Fri, Mar 07, 2025 at 09:33:05AM -0500, Rodrigo Vivi wrote:
> On Fri, Mar 07, 2025 at 06:21:12PM +0530, Raag Jadav wrote:
...
> > + case REG_FAN_SPEED:
> > + if (xe->info.platform == XE_BATTLEMAGE || xe->info.platform == XE_DG2) {
>
> we should probably have a has_fan_control flag in the platform definition struct so you
> don't need to do platform checks here and it gets easier when we need to add new platforms.
My experience with struct level flags has mostly been with high stakes
features which require maintaining a state (usually atomic), and I'm not
sure if fan control is worth having one of them.
Raag
More information about the Intel-xe
mailing list