[PATCH v2] drm/xe/hwmon: expose fan speed

[Raag Jadav]

On Fri, Mar 07, 2025 at 07:58:26PM +0200, Raag Jadav wrote:
> On Fri, Mar 07, 2025 at 09:33:05AM -0500, Rodrigo Vivi wrote:
> > On Fri, Mar 07, 2025 at 06:21:12PM +0530, Raag Jadav wrote:
> 
> ...
> 
> > > +	case REG_FAN_SPEED:
> > > +		if (xe->info.platform == XE_BATTLEMAGE || xe->info.platform == XE_DG2) {
> > 
> > we should probably have a has_fan_control flag in the platform definition struct so you
> > don't need to do platform checks here and it gets easier when we need to add new platforms.
> 
> My experience with struct level flags has mostly been with high stakes
> features which require maintaining a state (usually atomic), and I'm not
> sure if fan control is worth having one of them.

I know it's always taken on a lighter note in drm but we might never
know the cost of it overtime.

https://lore.kernel.org/netdev/20231129072756.3684495-1-lixiaoyan@google.com/

Raag