✓ CI.checkpatch: success for drm/xe: fix devcoredump chunk alignmnent calculation (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu May 1 01:29:55 UTC 2025
== Series Details ==
Series: drm/xe: fix devcoredump chunk alignmnent calculation (rev2)
URL : https://patchwork.freedesktop.org/series/148393/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8d34d415374ef089dc754c8176c381e64b4e9be1
Author: Arnd Bergmann <arnd at arndb.de>
Date: Wed Apr 30 18:25:45 2025 -0700
drm/xe: fix devcoredump chunk alignmnent calculation
The device core dumps are copied in 1.5GB chunks, which leads to a
link-time error on 32-bit builds because of the 64-bit division not
getting trivially turned into mask and shift operations:
ERROR: modpost: "__moddi3" [drivers/gpu/drm/xe/xe.ko] undefined!
On top of this, I noticed that the ALIGN_DOWN() usage here cannot
work because that is only defined for power-of-two alignments.
Change ALIGN_DOWN into an explicit div_u64_rem() that avoids the
link error and hopefully produces the right results.
Doing a 1.5GB kvmalloc() does seem a bit suspicious as well, e.g.
this will clearly fail on any 32-bit platform and is also likely
to run out of memory on 64-bit systems under memory pressure, so
using a much smaller power-of-two chunk size might be a good idea
instead.
v2:
- Always call div_u64_rem (Matt)
Reported-by: kernel test robot <lkp at intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504251238.JsNgFeFc-lkp@intel.com/
Fixes: c4a2e5f865b7 ("drm/xe: Add devcoredump chunking")
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 16612b54f368e7a6a1a170d3f2ecb1fd005ae55c drm-intel
8d34d415374e drm/xe: fix devcoredump chunk alignmnent calculation
More information about the Intel-xe
mailing list