[PATCH] drm/i915/backlight: drop dmesg suggestion to file bugs

[Tvrtko Ursulin]

On 29/04/2025 12:25, Jani Nikula wrote:
> Drop the FDO_BUG_URL from the source, and stop suggesting to file bugs
> on DPCD backlight issues. We don't do this anywhere else in display,
> this isn't a special snowflake.
> 
> As a consequence, also drop the dependency on i915_utils.h from
> intel_dp_aux_backlight.c.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 +--
>   drivers/gpu/drm/i915/i915_utils.h                     | 2 --
>   2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 20ab90acb351..271b27c9de51 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -36,7 +36,6 @@
>   
>   #include <drm/drm_print.h>
>   
> -#include "i915_utils.h"
>   #include "intel_backlight.h"
>   #include "intel_display_core.h"
>   #include "intel_display_types.h"
> @@ -149,7 +148,7 @@ intel_dp_aux_supports_hdr_backlight(struct intel_connector *connector)
>   	    !(connector->base.hdr_sink_metadata.hdmi_type1.metadata_type &
>   	      BIT(HDMI_STATIC_METADATA_TYPE1))) {
>   		drm_info(display->drm,
> -			 "[CONNECTOR:%d:%s] Panel is missing HDR static metadata. Possible support for Intel HDR backlight interface is not used. If your backlight controls don't work try booting with i915.enable_dpcd_backlight=%d. needs this, please file a _new_ bug report on drm/i915, see " FDO_BUG_URL " for details.\n",
> +			 "[CONNECTOR:%d:%s] Panel is missing HDR static metadata. Possible support for Intel HDR backlight interface is not used. If your backlight controls don't work try booting with i915.enable_dpcd_backlight=%d.\n",
>   			 connector->base.base.id, connector->base.name,
>   			 INTEL_DP_AUX_BACKLIGHT_FORCE_INTEL);
>   		return false;
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 609214231ffc..f7fb40cfdb70 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -40,8 +40,6 @@
>   struct drm_i915_private;
>   struct timer_list;
>   
> -#define FDO_BUG_URL "https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html"
> -
>   #define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
>   			     __stringify(x), (long)(x))
>   

Acked-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>

Regards,

Tvrtko