[PATCH 1/4] drm/i915/alpm: Clear ALPM registers when disabling ALPM

Jouni Högander jouni.hogander at intel.com
Tue May 6 07:00:26 UTC 2025


Currently ALPM disable is using rmw. There is no reason to use that. Just
clear registers.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 1bf08b80c23f..d48d1e6cc356 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -561,13 +561,8 @@ void intel_alpm_disable(struct intel_dp *intel_dp)
 
 	mutex_lock(&intel_dp->alpm_parameters.lock);
 
-	intel_de_rmw(display, ALPM_CTL(display, cpu_transcoder),
-		     ALPM_CTL_ALPM_ENABLE | ALPM_CTL_LOBF_ENABLE |
-		     ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
-
-	intel_de_rmw(display,
-		     PORT_ALPM_CTL(cpu_transcoder),
-		     PORT_ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
+	intel_de_write(display, ALPM_CTL(display, cpu_transcoder), 0);
+	intel_de_write(display, PORT_ALPM_CTL(dp_to_dig_port(intel_dp)->base.port), 0);
 
 	drm_dbg_kms(display->drm, "Disabling ALPM\n");
 	mutex_unlock(&intel_dp->alpm_parameters.lock);
-- 
2.43.0



More information about the Intel-xe mailing list