✗ CI.checkpatch: warning for drm/i915: irq_lock refactoring, move to display
Patchwork
patchwork at emeril.freedesktop.org
Tue May 6 13:14:21 UTC 2025
== Series Details ==
Series: drm/i915: irq_lock refactoring, move to display
URL : https://patchwork.freedesktop.org/series/148637/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 6e1a127291305b41eb4a6cf0c1f1ba1d205e7c23
Author: Jani Nikula <jani.nikula at intel.com>
Date: Tue May 6 16:06:50 2025 +0300
drm/i915/irq: move i915->irq_lock to display->irq.lock
Observe that i915->irq_lock is no longer used to protect anything
outside of display. Make it a display thing.
This allows us to remove the ugly #define irq_lock irq.lock hack from xe
compat header.
Note that this is slightly more subtle than it first looks. For i915,
there's no functional change here. The lock is moved. However, for xe,
we'll now have *two* locks, xe->irq.lock and display->irq.lock. These
should protect different things, though. Indeed, nesting in the past
would've lead to a deadlock because they were the same lock.
With the i915 references gone, we can make a handful more files
independent of i915_drv.h.
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch 9f365ea4cf81b0d81ad82903e5605894ca4aba98 drm-intel
0af28680f2fa drm/i915/irq: move locking inside vlv_display_irq_reset()
e10f1fcca39e drm/i915/irq: move locking inside valleyview_{enable, disable}_display_irqs()
dc95d845089a drm/i915/irq: move locking inside vlv_display_irq_postinstall()
fe96240a1509 drm/i915/irq: split out i915_display_irq_postinstall()
d5b5e7efa715 drm/i915/irq: split out i965_display_irq_postinstall()
5ea0118d752e drm/i915/irq: make i915_enable_asle_pipestat() static
362fac76ddfc drm/i915/rps: refactor display rps support
-:115: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#115: FILE: drivers/gpu/drm/i915/display/intel_display_rps.h:30:
+}
+static inline void intel_display_rps_mark_interactive(struct intel_display *display,
-:120: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#120: FILE: drivers/gpu/drm/i915/display/intel_display_rps.h:35:
+}
+static inline void ilk_display_rps_enable(struct intel_display *display)
-:123: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#123: FILE: drivers/gpu/drm/i915/display/intel_display_rps.h:38:
+}
+static inline void ilk_display_rps_disable(struct intel_display *display)
-:126: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#126: FILE: drivers/gpu/drm/i915/display/intel_display_rps.h:41:
+}
+static inline void ilk_display_rps_irq_handler(struct intel_display *display)
-:180: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#180:
deleted file mode 100644
total: 0 errors, 1 warnings, 4 checks, 134 lines checked
6e1a12729130 drm/i915/irq: move i915->irq_lock to display->irq.lock
More information about the Intel-xe
mailing list