[PATCH v2 0/3] ALPM rework and fixes
Jouni Högander
jouni.hogander at intel.com
Tue May 6 14:49:09 UTC 2025
Currently there are couple of problems in ALPM implelementation:
1. ALPM registers are written while PSR/ Panel Replay is kept
enabled. This is causing following error messages on PTL:
"xe 0000:00:02.0: [drm] *ERROR* Timeout waiting for DDI BUF A to
get active".
This is fixed by enabling ALPM only once when needed.
2. ALPM is never disabled when used by PSR/Panel Replay. I.e. if PSR
is once enabled ALPM is left enabled for good when PSR is
disabled. This is fixed by using intel_alpm_disable and calling it
for both cases: LOBF disable and PSR disable.
3. ALPM sink disable is done in PSR code. This is not logical as it's
enabled in ALPM code. There are two options to tackle this. Either
move sink disable or remove it completely. This patch set is moving
it to intel_alpm.c
Most critical fix in the set is 1. That can be merged separately and
review of rest of the patches can be continued. The fix is implemented
in patch 3/3.
v2:
- continue using rmw when disabling ALPM
- take into account disabled hw in old_crtc_state
Jouni Högander (3):
drm/i915/alpm: Move disabling sink ALPM to intel_alpm.c
drm/i915/alpm: Disable ALPM rework
drm/i915/alpm: Stop writing ALPM registers when PSR is enabled
drivers/gpu/drm/i915/display/intel_alpm.c | 70 ++++++++++----------
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
drivers/gpu/drm/i915/display/intel_psr.c | 7 +-
3 files changed, 36 insertions(+), 43 deletions(-)
--
2.43.0
More information about the Intel-xe
mailing list