✗ CI.checkpatch: warning for drm/xe/ggtt: Stop relying on GGTT internals. (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue May 6 21:48:35 UTC 2025


== Series Details ==

Series: drm/xe/ggtt: Stop relying on GGTT internals. (rev2)
URL   : https://patchwork.freedesktop.org/series/148602/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 7545878852524a94cc2c285888d0aa6218cd0bb1
Author: Maarten Lankhorst <dev at lankhorst.se>
Date:   Mon May 5 14:19:23 2025 +0200

    drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests
    
    Add a function to init ggtt for kunit, and use the GGTT function for
    initialising the GGTT node without populating it. This
    prevents the test from ever knowing about struct xe_ggtt.
    
    Signed-off-by: Maarten Lankhorst <dev at lankhorst.se>
+ /mt/dim checkpatch 842c3c276c106040f9b96d72b9df35ed6aed9ae9 drm-intel
8da2a342b6b7 drm/xe: Use xe_ggtt_map_bo_unlocked for resume
cef6b6dd9913 drm/xe: Add xe_ggtt_might_lock
f5f96cacbe72 drm/xe: Add xe_ggtt_alloc
-:33: WARNING:LINE_SPACING: Missing a blank line after declarations
#33: FILE: drivers/gpu/drm/xe/xe_ggtt.c:174:
+	struct xe_ggtt *ggtt = drmm_kzalloc(&tile_to_xe(tile)->drm, sizeof(*ggtt), GFP_KERNEL);
+	if (ggtt)

total: 0 errors, 1 warnings, 0 checks, 45 lines checked
2a277f4e2b74 drm/xe/display: Remove dereferences of ggtt for tile id
c18793572cf9 drm/xe/ggtt: Seperate flags and address in PTE encoding
-:4: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'?
#4: 
Subject: [PATCH] drm/xe/ggtt: Seperate flags and address in PTE encoding
                              ^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 180 lines checked
0b6ea3193142 drm/xe/display: Dont poke into GGTT internals to fill a DPT
-:54: WARNING:LINE_SPACING: Missing a blank line after declarations
#54: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:66:
+			u64 addr = xe_bo_addr(bo, src_idx * XE_PAGE_SIZE, XE_PAGE_SIZE);
+			iosys_map_wr(map, *dpt_ofs, u64, pte | addr);

total: 0 errors, 1 warnings, 0 checks, 79 lines checked
e1e9d69011d7 drm/xe/display: Convert GGTT mapping to use pte_encode_flags
75697d8741ae drm/xe: Remove pte_encode_bo callback
e1f820befe01 drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset
754587885252 drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests




More information about the Intel-xe mailing list