✗ CI.checkpatch: warning for drm/{i915, xe}: convert i915->display and xe->display into pointers (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Wed May 7 17:05:16 UTC 2025
== Series Details ==
Series: drm/{i915, xe}: convert i915->display and xe->display into pointers (rev2)
URL : https://patchwork.freedesktop.org/series/148684/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 1f9bdbf842ccdd925af3a5b606d16b0b83fc8f0c
Author: Jani Nikula <jani.nikula at intel.com>
Date: Wed May 7 18:22:54 2025 +0300
drm/{i915, xe}: convert i915 and xe display members into pointers
As the first step towards making struct intel_display an opaque pointer
in i915 and xe drivers, convert the struct drm_i915_private and struct
xe_device display members into pointers.
Initially, add temporary struct intel_display __display members, and
point display at it to avoid dynamic allocation. In the future, we can
drop this, and switch to dynamic allocation.
The conversion is done simply with sed:
sed -i 's/&\([a-zA-Z0-9_>.-]*\)\(dev_priv\|i915\|xe\)->display\([^.]\)/\1\2->display\3/g' \
$(git ls-files -- drivers/gpu/drm/i915 drivers/gpu/drm/xe)
sed -i 's/\(dev_priv\|i915\|xe\)->display\./\1->display->/g' \
$(git ls-files -- drivers/gpu/drm/i915 drivers/gpu/drm/xe)
With a couple of manual tweaks on top.
v2: Initialize i915->display also in selftest mock_gem_device()
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch c3be982edfd7bb6de5d4d3346d5d4189d7453d8d drm-intel
6f581313ea6c drm/xe/rpm: use to_xe_device() instead of container_of
c2e08cb021a4 drm/xe/display: do not reference xe->display inline
b70f6037aaa9 drm/i915: do not reference i915->display inline
1f9bdbf842cc drm/{i915, xe}: convert i915 and xe display members into pointers
-:17: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#17:
sed -i 's/&\([a-zA-Z0-9_>.-]*\)\(dev_priv\|i915\|xe\)->display\([^.]\)/\1\2->display\3/g' \
total: 0 errors, 1 warnings, 0 checks, 823 lines checked
More information about the Intel-xe
mailing list