✗ CI.checkpatch: warning for drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

[Patchwork]

== Series Details ==

Series: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
URL   : https://patchwork.freedesktop.org/series/148712/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f5649a1b78309cd77bbacedfd5263f4fbb637164
Author: Jonathan Cavitt <jonathan.cavitt at intel.com>
Date:   Wed May 7 15:57:26 2025 +0000

    drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
    
    Add support for userspace to request a list of observed faults
    from a specified VM.
    
    v2:
    - Only allow querying of failed pagefaults (Matt Brost)
    
    v3:
    - Remove unnecessary size parameter from helper function, as it
      is a property of the arguments. (jcavitt)
    - Remove unnecessary copy_from_user (Jainxun)
    - Set address_precision to 1 (Jainxun)
    - Report max size instead of dynamic size for memory allocation
      purposes.  Total memory usage is reported separately.
    
    v4:
    - Return int from xe_vm_get_property_size (Shuicheng)
    - Fix memory leak (Shuicheng)
    - Remove unnecessary size variable (jcavitt)
    
    v5:
    - Rename ioctl to xe_vm_get_faults_ioctl (jcavitt)
    - Update fill_property_pfs to eliminate need for kzalloc (Jianxun)
    
    v6:
    - Repair and move fill_faults break condition (Dan Carpenter)
    - Free vm after use (jcavitt)
    - Combine assertions (jcavitt)
    - Expand size check in xe_vm_get_faults_ioctl (jcavitt)
    - Remove return mask from fill_faults, as return is already -EFAULT or 0
      (jcavitt)
    
    v7:
    - Revert back to using xe_vm_get_property_ioctl
    - Apply better copy_to_user logic (jcavitt)
    
    v8:
    - Fix and clean up error value handling in ioctl (jcavitt)
    - Reapply return mask for fill_faults (jcavitt)
    
    v9:
    - Future-proof size logic for zero-size properties (jcavitt)
    - Add access and fault types (Jianxun)
    - Remove address type (Jianxun)
    
    v10:
    - Remove unnecessary switch case logic (Raag)
    - Compress size get, size validation, and property fill functions into a
      single helper function (jcavitt)
    - Assert valid size (jcavitt)
    
    v11:
    - Remove unnecessary else condition
    - Correct backwards helper function size logic (jcavitt)
    
    v12:
    - Use size_t instead of int (Raag)
    
    v13:
    - Remove engine class and instance (Ivan)
    
    v14:
    - Map access type, fault type, and fault level to user macros (Matt
      Brost, Ivan)
    
    v15:
    - Remove unnecessary size assertion (jcavitt)
    
    v16:
    - Nit fixes (Matt Brost)
    
    Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
    Suggested-by: Matthew Brost <matthew.brost at intel.com>
    Reviewed-by: Shuicheng Lin <shuicheng.lin at intel.com>
    Acked-by: Matthew Brost <matthew.brost at intel.com>
    Cc: Jainxun Zhang <jianxun.zhang at intel.com>
    Cc: Shuicheng Lin <shuicheng.lin at intel.com>
    Cc: Raag Jadav <raag.jadav at intel.com>
    Cc: Ivan Briano <ivan.briano at intel.com>
+ /mt/dim checkpatch 12ed58de6491fc48168f29de1c0fa9e9917b858d drm-intel
b8c3d9c09b45 drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs
cc775cef5f09 drm/xe/xe_gt_pagefault: Move pagefault struct to header
-:42: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 223 lines checked
0614f22af0c3 drm/xe/uapi: Define drm_xe_vm_get_property
-:56: WARNING:LONG_LINE: line length of 130 exceeds 100 columns
#56: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_VM_GET_PROPERTY		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_GET_PROPERTY, struct drm_xe_vm_get_property)

total: 0 errors, 1 warnings, 0 checks, 110 lines checked
ce0683c6148e drm/xe/xe_vm: Add per VM fault info
-:173: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#173: FILE: drivers/gpu/drm/xe/xe_vm.c:823:
+	if (!e) {
+		drm_warn(&vm->xe->drm,

total: 0 errors, 1 warnings, 0 checks, 225 lines checked
f5649a1b7830 drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
-:201: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#201: FILE: drivers/gpu/drm/xe/xe_vm.c:3697:
+	if (XE_IOCTL_DBG(xe, args->reserved[0] || args->reserved[1] ||
+			     args->reserved[2]))

total: 0 errors, 0 warnings, 1 checks, 130 lines checked