[PATCH v24 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

[ivan.briano at intel.com]

On Wed, May 07, 2025 at 12:32:49PM -0700, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.vivi at intel.com> 
> Sent: Wednesday, May 7, 2025 12:24 PM
> To: Cavitt, Jonathan <jonathan.cavitt at intel.com>
> Cc: intel-xe at lists.freedesktop.org; Gupta, saurabhg <saurabhg.gupta at intel.com>; Zuo, Alex <alex.zuo at intel.com>; joonas.lahtinen at linux.intel.com; Brost, Matthew <matthew.brost at intel.com>; Zhang, Jianxun <jianxun.zhang at intel.com>; Lin, Shuicheng <shuicheng.lin at intel.com>; dri-devel at lists.freedesktop.org; Wajdeczko, Michal <Michal.Wajdeczko at intel.com>; Mrozek, Michal <michal.mrozek at intel.com>; Jadav, Raag <raag.jadav at intel.com>; Harrison, John C <john.c.harrison at intel.com>; Briano, Ivan <ivan.briano at intel.com>; Auld, Matthew <matthew.auld at intel.com>; dafna.hirschfield at intel.com
> Subject: Re: [PATCH v24 3/5] drm/xe/uapi: Define drm_xe_vm_get_property
> > 
> > On Wed, May 07, 2025 at 03:57:24PM +0000, Jonathan Cavitt wrote:
> > > Add initial declarations for the drm_xe_vm_get_property ioctl.
> > > 
> > > v2:
> > > - Expand kernel docs for drm_xe_vm_get_property (Jianxun)
> > > 
> > > v3:
> > > - Remove address type external definitions (Jianxun)
> > > - Add fault type to xe_drm_fault struct (Jianxun)
> > > 
> > > v4:
> > > - Remove engine class and instance (Ivan)
> > > 
> > > v5:
> > > - Add declares for fault type, access type, and fault level (Matt Brost,
> > >   Ivan)
> > > 
> > > v6:
> > > - Fix inconsistent use of whitespace in defines
> > > 
> > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> > > Reviewed-by: Shuicheng Lin <shuicheng.lin at intel.com>
> > > Acked-by: Matthew Brost <matthew.brost at intel.com>
> > > Cc: Zhang Jianxun <jianxun.zhang at intel.com>
> > > Cc: Ivan Briano <ivan.briano at intel.com>
> > > Cc: Matthew Brost <matthew.brost at intel.com>
> > 
> > We are already in the v25 of this series and we still don't have the userspace
> > PR/MR to reference here and no ack from the user space?
> 
> The userspace PR/MR is in the cover letter:
> """
> uAPI: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32987
> """
> 
> > 
> > Sometimes faster series iterations are counterintuitively slowing things down.
> 
> Who should I be messaging to get userspace acks from?
> -Jonathan Cavitt
> 

Acked-by: Ivan Briano <ivan.briano at intel.com>

Do note that the MR you point at was closed for reasons, though we can
certainly just reopen it and update it to the UAPI changes since then.
But the actual work to get rid of the scratch page that is a
pre-requisite to enable this extension is not done yet and will still
take a bit. We do need the page fault reports for it though.