✗ CI.checkpatch: warning for drm/i915: refactor VLV IOSF SB for display usage (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu May 8 10:10:11 UTC 2025


== Series Details ==

Series: drm/i915: refactor VLV IOSF SB for display usage (rev2)
URL   : https://patchwork.freedesktop.org/series/148265/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ed0c89c303763ef4980790cdca1c76440eb35c35
Author: Jani Nikula <jani.nikula at intel.com>
Date:   Thu May 8 13:03:42 2025 +0300

    drm/i915: ensure correct VLV IOSF SB units have been get/put
    
    Add some extra paranoia to check correct use of the VLV IOSF SB
    get/put/read/write.
    
    Signed-off-by: Jani Nikula <jani.nikula at intel.com>
+ /mt/dim checkpatch ca0305cadc2d34c8887b891b96226af17571b2a3 drm-intel
113a2c1dc7b9 drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch]
-:236: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#236: 
rename from drivers/gpu/drm/i915/vlv_sideband.c

total: 0 errors, 1 warnings, 0 checks, 207 lines checked
45ddaca768d5 drm/i915: add generic read/write functions for VLV IOSF SB
-:148: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#148: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:31:
+static inline u32 vlv_iosf_sb_read(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr)

-:148: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#148: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:31:
 }
+static inline u32 vlv_iosf_sb_read(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr)

-:154: WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#154: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:35:
+static inline int vlv_iosf_sb_write(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr, u32 val)

-:154: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#154: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:35:
 }
+static inline int vlv_iosf_sb_write(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr, u32 val)

total: 0 errors, 2 warnings, 2 checks, 130 lines checked
3b016ed40fc2 drm/i915: rewrite VLV IOSF SB unit specific read/write functions
ea2dd2a7084f drm/i915: switch i915 core to generic VLV IOSF SB functions
b1e295400ccb drm/i915: move VLV IOSF SB unit specific helpers under display
-:162: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#162: 
new file mode 100644

-:307: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#307: FILE: drivers/gpu/drm/i915/display/vlv_sideband.h:90:
+}
+static inline void vlv_dpio_write(struct drm_i915_private *i915,

total: 0 errors, 1 warnings, 1 checks, 599 lines checked
dc55478a4444 drm/i915: convert VLV IOSF SB interface to struct drm_device
-:1829: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1829: FILE: drivers/gpu/drm/i915/display/vlv_sideband.h:90:
 }
+static inline void vlv_dpio_write(struct drm_device *drm,

-:2254: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#2254: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:30:
 }
+static inline u32 vlv_iosf_sb_read(struct drm_device *drm, enum vlv_iosf_sb_unit unit, u32 addr)

-:2259: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#2259: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:34:
+static inline int vlv_iosf_sb_write(struct drm_device *drm, enum vlv_iosf_sb_unit unit, u32 addr, u32 val)

-:2259: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#2259: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:34:
 }
+static inline int vlv_iosf_sb_write(struct drm_device *drm, enum vlv_iosf_sb_unit unit, u32 addr, u32 val)

-:2264: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#2264: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:38:
 }
+static inline void vlv_iosf_sb_put(struct drm_device *drm, unsigned long ports)

total: 0 errors, 1 warnings, 4 checks, 2084 lines checked
172a6661545f drm/i915: rename VLV IOSF SB ports parameter to unit_mask
ed0c89c30376 drm/i915: ensure correct VLV IOSF SB units have been get/put




More information about the Intel-xe mailing list