[PATCH v3 1/2] drm/i915/alpm: Make intel_alpm_enable_sink available for PSR

[Kandpal, Suraj]

> -----Original Message-----
> From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Jouni
> Högander
> Sent: Thursday, May 8, 2025 7:47 PM
> To: intel-gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org
> Cc: Manna, Animesh <animesh.manna at intel.com>; Hogander, Jouni
> <jouni.hogander at intel.com>
> Subject: [PATCH v3 1/2] drm/i915/alpm: Make intel_alpm_enable_sink
> available for PSR
> 
> We want to enable sink ALPM from PSR code. Make intel_alpm_enable_sink
> available for PSR.

Add more description here saying while at it add the documentation for that function too.

> 
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 11 +++++++++--
> drivers/gpu/drm/i915/display/intel_alpm.h |  2 ++
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 1bf08b80c23f..9442483058d2 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -426,8 +426,15 @@ void intel_alpm_pre_plane_update(struct
> intel_atomic_state *state,
>  	}
>  }
> 
> -static void intel_alpm_enable_sink(struct intel_dp *intel_dp,
> -				   const struct intel_crtc_state *crtc_state)
> +/**
> + * intel_alpm_enable_sink - Enable ALPM on sink
> + * @intel_dp: Intel DP struct
> + * @crtc_state: Intel CRTC struct

Shouldn't this be Intel crtc state struct
Nit: Maybe Intel dp struct instead of Intel DP same for crtc state

Other than that
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal at intel.com>


> + *
> + * This function is enabling DPCD on sink based on information from
> crtc_state.
> + */
> +void intel_alpm_enable_sink(struct intel_dp *intel_dp,
> +			    const struct intel_crtc_state *crtc_state)
>  {
>  	u8 val;
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h
> b/drivers/gpu/drm/i915/display/intel_alpm.h
> index d7126d65b60f..c9fe21e3e72c 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.h
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.h
> @@ -23,6 +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp
> *intel_dp,
>  				    struct drm_connector_state *conn_state);
> void intel_alpm_configure(struct intel_dp *intel_dp,
>  			  const struct intel_crtc_state *crtc_state);
> +void intel_alpm_enable_sink(struct intel_dp *intel_dp,
> +			    const struct intel_crtc_state *crtc_state);
>  void intel_alpm_pre_plane_update(struct intel_atomic_state *state,
>  				 struct intel_crtc *crtc);
>  void intel_alpm_post_plane_update(struct intel_atomic_state *state,
> --
> 2.43.0