✗ CI.checkpatch: warning for Track FAST_REQ H2Gs to report where errors came from

Patchwork patchwork at emeril.freedesktop.org
Mon May 12 21:59:02 UTC 2025


== Series Details ==

Series: Track FAST_REQ H2Gs to report where errors came from
URL   : https://patchwork.freedesktop.org/series/148912/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b87b1014e79a05064fda3d23695417b7de9f5c9d
Author: John Harrison <John.C.Harrison at Intel.com>
Date:   Mon May 12 14:53:24 2025 -0700

    drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from
    
    Most H2G messages are FAST_REQ which means no synchronous response is
    expected. The messages are sent as fire-and-forget with no tracking.
    However, errors can still be returned when something goes unexpectedly
    wrong. That leads to confusion due to not being able to match up the
    error response to the originating H2G.
    
    So add support for tracking the FAST_REQ H2Gs and matching up an error
    response to its originator. This is only enabled in XE_DEBUG builds
    given that such errors should never happen in a working system and
    there is an overhead for the tracking.
    
    Further, if XE_DEBUG_GUC is enabled then even more memory and time is
    used to record the call stack of each H2G and report that with the
    error. That makes it much easier to work out where a specific H2G came
    from if there are multiple code paths that can send it.
    
    v2: Some re-wording of comments and prints, more consistent use of #if
    vs stub functions - review feedback from Daniele & Michal).
    v3: Split config change to separate patch, improve a debug print
    (review feedback from Michal).
    v4: Bunch of minor tweaks (review feedback from Michal).
    
    Original-i915-code: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
    Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
    Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
+ /mt/dim checkpatch f28b1630b0e26e108cf5e2d9379bfed92dc4113f drm-intel
0ff07816dba9 drm/xe/guc: Remove double blank line
00c02f0177d8 drm/xe/guc: Add missing H2G error code definitions
f40937880781 drm/xe/guc: Rename CONFIG_XE_LARGE_GUC_BUFFER
-:23: WARNING:CONFIG_DESCRIPTION: please write a help paragraph that fully describes the config symbol with at least 4 lines
#23: FILE: drivers/gpu/drm/xe/Kconfig.debug:89:
+config DRM_XE_DEBUG_GUC
+        bool "Enable extra GuC related debug options"
+        depends on DRM_XE_DEBUG
         default n
         help
           Choose this option when debugging guc issues.
+          The GuC log buffer is increased to the maximum allowed, which should
+          The GuC log buffer is increased to the maximum allowed, which should
+          be large enough for complex issues.
 
           Recommended for driver developers only.
 

total: 0 errors, 1 warnings, 0 checks, 25 lines checked
b87b1014e79a drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from




More information about the Intel-xe mailing list