✗ CI.checkpatch: warning for drm/i915/ptl: Use everywhere the correct DDI port clock select mask

Patchwork patchwork at emeril.freedesktop.org
Tue May 13 09:17:51 UTC 2025


== Series Details ==

Series: drm/i915/ptl: Use everywhere the correct DDI port clock select mask
URL   : https://patchwork.freedesktop.org/series/148893/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 27945843ea5e7e95ec6116751f3929f974d29bda
Author: Imre Deak <imre.deak at intel.com>
Date:   Mon May 12 17:26:00 2025 +0300

    drm/i915/ptl: Use everywhere the correct DDI port clock select mask
    
    The PTL XELPDP_PORT_CLOCK_CTL register XELPDP_DDI_CLOCK_SELECT field's
    size is 5 bits vs. the earlier platforms where its size is 4 bits. Make
    sure the field is read-out/programmed everywhere correctly, according to
    the above.
    
    Cc: Mika Kahola <mika.kahola at intel.com>
    Cc: stable at vger.kernel.org # v6.13+
    Signed-off-by: Imre Deak <imre.deak at intel.com>
    Tested-by: Mika Kahola <mika.kahola at intel.com>
    Reviewed-by: Mika Kahola <mika.kahola at intel.com>
+ /mt/dim checkpatch c9de1544553b1d6112ccc32977b6d56881cedcea drm-intel
27945843ea5e drm/i915/ptl: Use everywhere the correct DDI port clock select mask
-:68: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#68: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3172:
+					    intel_mtl_tbt_clock_select(display, crtc_state->port_clock));

-:114: WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#114: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:198:
+							 _XE3_DDI_CLOCK_SELECT_MASK : _XELPDP_DDI_CLOCK_SELECT_MASK)

-:115: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#115: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:199:
+#define   XELPDP_DDI_CLOCK_SELECT_PREP(display, val)	(DISPLAY_VER(display) >= 30 ? \
+							 REG_FIELD_PREP(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \
+							 REG_FIELD_PREP(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:116: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#116: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:200:
+							 REG_FIELD_PREP(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \

-:117: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#117: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:201:
+							 REG_FIELD_PREP(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:118: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#118: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:202:
+#define   XELPDP_DDI_CLOCK_SELECT_GET(display, val)	(DISPLAY_VER(display) >= 30 ? \
+							 REG_FIELD_GET(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \
+							 REG_FIELD_GET(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:119: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#119: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:203:
+							 REG_FIELD_GET(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \

-:120: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#120: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:204:
+							 REG_FIELD_GET(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:124: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 7 warnings, 2 checks, 91 lines checked




More information about the Intel-xe mailing list