✗ CI.checkpatch: warning for AuxCCS handling and render compression modifiers (rev6)

Patchwork patchwork at emeril.freedesktop.org
Wed May 14 23:04:18 UTC 2025


== Series Details ==

Series: AuxCCS handling and render compression modifiers (rev6)
URL   : https://patchwork.freedesktop.org/series/144186/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 68ea8bb866be85f19914bf470bb2c7422563e777
Author: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
Date:   Wed May 14 14:39:01 2025 +0100

    drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe
    
    Now that we have fixed the DPT handling we can undo the nerf which was
    done in cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if
    built for Xe").
    
    Tested with KDE Wayland, on Lenovo Carbon X1 ADL-P:
    
            [PLANE:32:plane 1A]: type=PRI
                    uapi: [FB:242] AR30 little-endian (0x30335241),0x100000000000008,2880x1800, visible=visible, src=2880.000000x1800.000000+0.000000+0.000000, dst=2880x1800+0+0, rotation=0 (0x00000001)
                    hw: [FB:242] AR30 little-endian (0x30335241),0x100000000000008,2880x1800, visible=yes, src=2880.000000x1800.000000+0.000000+0.000000, dst=2880x1800+0+0, rotation=0 (0x00000001)
    
    Display working fine - no artefacts, no DMAR/PIPE faults.
    
    v2:
     * Adjust patch title. (Rodrigo)
    
    Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
    References: cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if built for Xe")
    Cc: José Roberto de Souza <jose.souza at intel.com>
    Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
+ /mt/dim checkpatch 3d6670fab64cb00b5e6ed80d2517147db533faf1 drm-intel
dfa226bbbe49 drm/xe: Clarify LRC size when allocating
260e8abd5bde drm/xe/xelp: Implement HSDES#16010904313 workarounds
-:127: CHECK:SPACING: spaces preferred around that '+' (ctx:VxW)
#127: FILE: drivers/gpu/drm/xe/xe_lrc.c:1021:
+	*cmd++ = __xe_lrc_regs_ggtt_addr(lrc)+ CTX_CMD_BUF_CCTL * sizeof(u32);
 	                                     ^

-:175: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#175: FILE: drivers/gpu/drm/xe/xe_lrc.c:1069:
+	start = cmd = map.vaddr;

total: 0 errors, 0 warnings, 2 checks, 190 lines checked
d6a2c5f66ba5 drm/xe/xelp: Add Wa_1607983814
7d96b7fa206a drm/xe: Use emit_flush_imm_ggtt helper instead of open coding
1519e0d6394b drm/xe/xelpg: Flush CCS when flushing caches
1aee67297c6d drm/xe: Flush L3 when flushing render cache
-:19: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#19: FILE: drivers/gpu/drm/xe/instructions/xe_gpu_commands.h:50:
+#define   PIPE_CONTROL_FLUSH_L3                         (1<<27)
                                                           ^

total: 0 errors, 0 warnings, 1 checks, 23 lines checked
6982b1b7f9b8 drm/xe/xelp: Quiesce memory traffic before invalidating auxccs
c5010cc3c990 drm/xe/xelp: Support auxccs invalidation on blitter
2568c84f0312 drm/xe/xelp: Use MI_FLUSH_DW_CCS on auxccs platforms
967567fa06fd drm/xe/xelp: Wait for AuxCCS invalidation to complete
156e0946fb03 drm/xe/xelp: Add AuxCCS invalidation to the buffer migration path
228d8aba474b drm/xe: Export xe_emit_aux_table_inv
777da9b0fe81 drm/xe/xelp: Add AuxCCS invalidation to the indirect context workarounds
8b59a5e22990 drm/xe: Use fb cached min alignment
7696fb5527b9 drm/xe: Flush GGTT writes after populating DPT
-:72: WARNING:MEMORY_BARRIER: memory barrier without comment
#72: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:115:
+	wmb();

total: 0 errors, 1 warnings, 0 checks, 66 lines checked
75fff0d5d226 drm/xe: Handle DPT in system memory
711c94c62ef8 drm/xe: Force flush system memory AuxCCS framebuffers before scan out
76fda48ea201 drm/xe/display: Add support for AuxCCS
-:83: CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#83: FILE: drivers/gpu/drm/xe/display/xe_fb_pin.c:95:
+	u64 (*pte_encode_bo)(struct xe_bo *bo, u64 bo_offset, u16 pat_index)
+		= ggtt->pt_ops->pte_encode_bo;

total: 0 errors, 0 warnings, 1 checks, 133 lines checked
68ea8bb866be drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if built for Xe")'
#10: 
done in cf48bddd31de ("drm/i915/display: Disable AuxCCS framebuffers if

-:16: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#16: 
		uapi: [FB:242] AR30 little-endian (0x30335241),0x100000000000008,2880x1800, visible=visible, src=2880.000000x1800.000000+0.000000+0.000000, dst=2880x1800+0+0, rotation=0 (0x00000001)

total: 1 errors, 1 warnings, 0 checks, 12 lines checked




More information about the Intel-xe mailing list