[PATCH] drm/xe/mocs: Check if all domains awake

Nilawar, Badal badal.nilawar at intel.com
Fri May 16 10:49:04 UTC 2025


On 06-05-2025 19:53, Tejas Upadhyay wrote:
> Check if all domains are awake specially for
> LNCF regs
>
> Fixes: 1182bc74b39b ("drm/xe: Fix MOCS debugfs LNCF readout")
> Improvements-suggested-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar at intel.com>
> ---
>   drivers/gpu/drm/xe/xe_mocs.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_mocs.c b/drivers/gpu/drm/xe/xe_mocs.c
> index 31dade91a089..0c737413fcb6 100644
> --- a/drivers/gpu/drm/xe/xe_mocs.c
> +++ b/drivers/gpu/drm/xe/xe_mocs.c
> @@ -775,22 +775,23 @@ void xe_mocs_init(struct xe_gt *gt)
>   void xe_mocs_dump(struct xe_gt *gt, struct drm_printer *p)
>   {
>   	struct xe_device *xe = gt_to_xe(gt);
> +	enum xe_force_wake_domains domain;
>   	struct xe_mocs_info table;
>   	unsigned int fw_ref, flags;
>   
>   	flags = get_mocs_settings(xe, &table);
>   
> +	domain = flags & HAS_LNCF_MOCS ? XE_FORCEWAKE_ALL : XE_FW_GT;
>   	xe_pm_runtime_get_noresume(xe);
> -	fw_ref = xe_force_wake_get(gt_to_fw(gt),
> -				   flags & HAS_LNCF_MOCS ?
> -				   XE_FORCEWAKE_ALL : XE_FW_GT);
> -	if (!fw_ref)
> +	fw_ref = xe_force_wake_get(gt_to_fw(gt), domain);
> +
> +	if (!xe_force_wake_ref_has_domain(fw_ref, domain))
>   		goto err_fw;
>   
>   	table.ops->dump(&table, flags, gt, p);
>   
> -	xe_force_wake_put(gt_to_fw(gt), fw_ref);
>   err_fw:
> +	xe_force_wake_put(gt_to_fw(gt), fw_ref);
>   	xe_pm_runtime_put(xe);
>   }
>   


More information about the Intel-xe mailing list