[PATCH 2/2] drm/xe: Add missing documentation of rpa_freq
Lucas De Marchi
lucas.demarchi at intel.com
Tue May 27 19:23:28 UTC 2025
On Wed, May 21, 2025 at 11:12:20AM -0700, Belgaumkar, Vinay wrote:
>
>On 5/21/2025 9:51 AM, Rodrigo Vivi wrote:
>>While at it, already adjust the rpe_freq frequency, to highlight
>>that both are calculated by PCODE at runtime.
>>
>>Fixes: c6aac2fa77a3 ("drm/xe: Introduce the RPa information")
>>Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
>>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>>Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>>---
>> drivers/gpu/drm/xe/xe_gt_freq.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>>diff --git a/drivers/gpu/drm/xe/xe_gt_freq.c b/drivers/gpu/drm/xe/xe_gt_freq.c
>>index 3293d89f1386..60d9354e7dbf 100644
>>--- a/drivers/gpu/drm/xe/xe_gt_freq.c
>>+++ b/drivers/gpu/drm/xe/xe_gt_freq.c
>>@@ -36,7 +36,10 @@
>> * - act_freq: The actual resolved frequency decided by PCODE.
>> * - cur_freq: The current one requested by GuC PC to the PCODE.
>> * - rpn_freq: The Render Performance (RP) N level, which is the minimal one.
>>+ * - rpa_freq: The Render Performance (RP) A level, which is the achiveable one.
>>+ * Calculated by PCODE at runtime based on multiple running conditions
>> * - rpe_freq: The Render Performance (RP) E level, which is the efficient one.
>>+ * Calculated by PCODE at runtime based on multiple running conditions
>
>Nit: Do we need full stop at the end of these sentences?
yeah, let's add them to be consistent with the other items
Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
Lucas De Marchi
>
>Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
>
>> * - rp0_freq: The Render Performance (RP) 0 level, which is the maximum one.
>> *
>> * device/tile#/gt#/freq0/<item>_freq *read-write* files:
More information about the Intel-xe
mailing list