✗ CI.checkpatch: warning for MADVISE FOR XE
Patchwork
patchwork at emeril.freedesktop.org
Tue May 27 21:35:53 UTC 2025
== Series Details ==
Series: MADVISE FOR XE
URL : https://patchwork.freedesktop.org/series/149550/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8efc3f700df0efaf26d998c615ee03862a64b1dd
Author: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
Date: Tue May 27 22:10:03 2025 +0530
drm/xe/bo: Update atomic_access attribute on madvise
Update the bo_atomic_access based on user-provided input and determine
the migration to smem during a CPU fault
v2 (Matthew Brost)
- Avoid cpu unmapping if bo is already in smem
- check atomics on smem too for ioctl
- Add comments
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
+ /mt/dim checkpatch 07b6736f75df3e60d5e20eda53ecb97f6d9a66c0 drm-intel
7f6424798069 Introduce drm_gpuvm_sm_map_ops_flags enums for sm_map_ops
e6fe68af7a54 drm/xe/uapi: Add madvise interface
-:37: WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#37: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_MADVISE DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_MADVISE, struct drm_xe_madvise)
total: 0 errors, 1 warnings, 0 checks, 121 lines checked
819ba9e2e009 drm/xe/vm: Add attributes struct as member of vma
d245db89a660 drm/xe/vma: Move pat_index to vma attributes
3d926afb1501 drm/xe/vma: Modify new_vma to accept struct xe_vma_mem_attr as parameter
93cca09e422f drm/gpusvm: Make drm_gpusvm_for_each_* macros public
-:224: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'range__' - possible side-effects?
#224: FILE: include/drm/drm_gpusvm.h:548:
+#define drm_gpusvm_for_each_range_safe(range__, next__, notifier__, start__, end__) \
+ for ((range__) = drm_gpusvm_range_find((notifier__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_range_next(range__); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = (next__), (next__) = __drm_gpusvm_range_next(range__))
-:224: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'next__' - possible side-effects?
#224: FILE: include/drm/drm_gpusvm.h:548:
+#define drm_gpusvm_for_each_range_safe(range__, next__, notifier__, start__, end__) \
+ for ((range__) = drm_gpusvm_range_find((notifier__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_range_next(range__); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = (next__), (next__) = __drm_gpusvm_range_next(range__))
-:224: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#224: FILE: include/drm/drm_gpusvm.h:548:
+#define drm_gpusvm_for_each_range_safe(range__, next__, notifier__, start__, end__) \
+ for ((range__) = drm_gpusvm_range_find((notifier__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_range_next(range__); \
+ (range__) && (drm_gpusvm_range_start(range__) < (end__)); \
+ (range__) = (next__), (next__) = __drm_gpusvm_range_next(range__))
-:257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'notifier__' - possible side-effects?
#257: FILE: include/drm/drm_gpusvm.h:581:
+#define drm_gpusvm_for_each_notifier(notifier__, gpusvm__, start__, end__) \
+ for ((notifier__) = drm_gpusvm_notifier_find((gpusvm__), (start__), (end__)); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = __drm_gpusvm_notifier_next(notifier__))
-:257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#257: FILE: include/drm/drm_gpusvm.h:581:
+#define drm_gpusvm_for_each_notifier(notifier__, gpusvm__, start__, end__) \
+ for ((notifier__) = drm_gpusvm_notifier_find((gpusvm__), (start__), (end__)); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = __drm_gpusvm_notifier_next(notifier__))
-:273: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'notifier__' - possible side-effects?
#273: FILE: include/drm/drm_gpusvm.h:597:
+#define drm_gpusvm_for_each_notifier_safe(notifier__, next__, gpusvm__, start__, end__) \
+ for ((notifier__) = drm_gpusvm_notifier_find((gpusvm__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_notifier_next(notifier__); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))
-:273: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'next__' - possible side-effects?
#273: FILE: include/drm/drm_gpusvm.h:597:
+#define drm_gpusvm_for_each_notifier_safe(notifier__, next__, gpusvm__, start__, end__) \
+ for ((notifier__) = drm_gpusvm_notifier_find((gpusvm__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_notifier_next(notifier__); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))
-:273: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end__' - possible side-effects?
#273: FILE: include/drm/drm_gpusvm.h:597:
+#define drm_gpusvm_for_each_notifier_safe(notifier__, next__, gpusvm__, start__, end__) \
+ for ((notifier__) = drm_gpusvm_notifier_find((gpusvm__), (start__), (end__)), \
+ (next__) = __drm_gpusvm_notifier_next(notifier__); \
+ (notifier__) && (drm_gpusvm_notifier_start(notifier__) < (end__)); \
+ (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))
total: 0 errors, 0 warnings, 8 checks, 248 lines checked
ae3927698d3b drm/xe/vm: Add a helper xe_vm_range_tilemask_tlb_invalidation()
355637e9a1a2 drm/xe/svm: Add xe_svm_ranges_zap_ptes_in_range() for PTE zapping
7812ed76f877 drm/xe/svm: Split system allocator vma incase of madvise call
a12baf509b9b drm/xe: Implement madvise ioctl for xe
-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 300 lines checked
e7fca0cbbd90 drm/xe: Allow CPU address mirror VMA unbind with gpu bindings for madvise
8908087fe603 drm/xe/svm : Add svm ranges migration policy on atomic access
df6fdefcfbf8 drm/xe/madvise: Update migration policy based on preferred location
d081210b1f13 drm/xe/svm: Support DRM_XE_SVM_ATTR_PAT memory attribute
4a216efb8ae6 drm/xe/uapi: Add flag for consulting madvise hints on svm prefetch
693c55c96b16 drm/xe/svm: Consult madvise preferred location in prefetch
2397fcb48be1 drm/xe/uapi: Add UAPI for querying VMA count and memory attributes
-:71: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#71: FILE: drivers/gpu/drm/xe/xe_vm.c:2193:
+ mem_attrs[i].preferred_mem_loc.migration_policy = vma->attr.preferred_loc.migration_policy;
-:170: WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#170: FILE: include/uapi/drm/xe_drm.h:125:
+#define DRM_IOCTL_XE_VM_QUERY_VMAS_ATTRS DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_QUERY_VMAS_ATTRS, struct drm_xe_vm_query_vmas_attr)
total: 0 errors, 2 warnings, 0 checks, 214 lines checked
8a11d0006b65 drm/xe/bo: Add attributes field to xe_bo
8efc3f700df0 drm/xe/bo: Update atomic_access attribute on madvise
More information about the Intel-xe
mailing list