✗ CI.checkpatch: warning for drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu May 29 18:22:16 UTC 2025


== Series Details ==

Series: drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency (rev2)
URL   : https://patchwork.freedesktop.org/series/149427/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
202708c00696422fd217223bb679a353a5936e23
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e599443893d63ab2d7cd7d3c58e36e2ff1dc4597
Author: Arnd Bergmann <arnd at arndb.de>
Date:   Thu May 29 10:23:56 2025 -0700

    drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency
    
    The XE driver can be built with or without VSEC support, but fails to link as
    built-in if vsec is in a loadable module:
    
    x86_64-linux-ld: vmlinux.o: in function `xe_vsec_init':
    (.text+0x1e83e16): undefined reference to `intel_vsec_register'
    
    The normal fix for this is to add a 'depends on INTEL_VSEC || !INTEL_VSEC',
    forcing XE to be a loadable module as well, but that causes a circular
    dependency:
    
            symbol DRM_XE depends on INTEL_VSEC
            symbol INTEL_VSEC depends on X86_PLATFORM_DEVICES
            symbol X86_PLATFORM_DEVICES is selected by DRM_XE
    
    The problem here is selecting a symbol from another subsystem, so change
    that as well and rephrase the 'select' into the corresponding dependency.
    Since X86_PLATFORM_DEVICES is 'default y', there is no change to
    defconfig builds here.
    
    Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
    Signed-off-by: Arnd Bergmann <arnd at arndb.de>
    Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
    Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
+ /mt/dim checkpatch 901190a062301f01d432d9cf164a6b013df3e745 drm-intel
e599443893d6 drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
The XE driver can be built with or without VSEC support, but fails to link as

total: 0 errors, 1 warnings, 0 checks, 15 lines checked




More information about the Intel-xe mailing list