[Libburn] libisofs patch

[Ben Jansens]

--WIyZ46R2i8wDzkSu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 06, 2004 at 09:37:25AM -0500, Todd Kulesza wrote:
> On Fri, 2004-02-06 at 08:46, Ben Jansens wrote:
> > Nice work :) I have one question. Why the empty sector before/after each
> > path table? I know mkisofs leaves a "blank" (with some self-gratuitous
> > comments in it) after the volume descriptors. But I found no reason for=
 this
> > in the iso9660 spec.
> >=20
>=20
> I thought mkisofs might have some reason for it; I've been comparing ISO
> images created with libisofs and mkisofs using a hex editor, and it's
> much easier to read them when all of the lines match up evenly.  I can
> take that bit out if you think it's unnecessary.  I didn't see anything
> about it one way or another in the ECMA-119 spec, not sure if it differs
> from iso9660 on this or not.

At the risk of sounding stupid...

I'm trying to find the 1-sector buffer that the comment claims exist. You
seem to be adding 2 sectors for the L path table, and 2 for the M, which
would leave a blank after each one (which is needed iirc). But I don't see
any extra sectors before the L path table. Is it actually there, or is this=
 a
phantom comment?

A side note on conventions: We're using /* XXX foo */ for todo's in the code
instead of /* FIXME: foo */.

Other than that I think the patch is some good progress! Thanks.

Ben

--WIyZ46R2i8wDzkSu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAJAgw8mPQRGtSu14RAvayAJ9ogk7WD9wDYuCSTDU4GhGXK57/3QCghb0U
1Nyy/ljRN0NO6VT+L+JR6X4=
=kO3k
-----END PGP SIGNATURE-----

--WIyZ46R2i8wDzkSu--