Adding new MBIM extension CID?

[Arnaud Desmier]

Done in attached patch.

Arnaud

On 10/04/2014 16:07, Aleksander Morgado wrote:
> On Thu, Apr 10, 2014 at 4:06 PM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
>> On Thu, Apr 10, 2014 at 2:40 PM, Arnaud Desmier <adesmier at sequans.com> wrote:
>>> OK, so I enabled again mbim-uuid.h within generated/Makefile.am.
>>>
>>> But instead of writing a mbim_service_custom_get_string I wrote a
>>> mbim_get_service_string. This function can retrieve service nickname for any
>>> service and is called instead of mbim_service_get_string that is
>>> automatically generated.
>>>
>>> I know the difference between mbim_service_get_string and
>>> mbim_get_service_string is really tiny and can confuse but I have no better
>>> name.
>> Well... that's pretty confusing actually.
>>
>> How about mbim_service_lookup_name()? The method actually looks for
>> the service name; either directly via the enum's get_string() for the
>> standard ones or looking for a match in the registered ones.
>>
>> Also, the method shouldn't received a MbimService; it should get a
>> guint, as the registered services are not included in the MbimService
>> enum (e.g. you cannot get a registered service value as a GEnum).
Oups... copy/paste issue :(
>
> Oh, one last thing, new methods need to be added in
> docs/reference/libmbim-glib (i.e. compile using --enable-gtk-doc and
> fix warnings)
>



-- IMPORTANT NOTICE: 

The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libmbim-devel/attachments/20140410/ae04ccac/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-custom-services.patch
Type: text/x-patch
Size: 12225 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libmbim-devel/attachments/20140410/ae04ccac/attachment-0001.bin>