QMI via MBIM for "FCC Authentication" fix

[Emil Ljungdahl]

On 04/04/16 16:23, Bjørn Mork wrote:
> Aleksander Morgado <aleksander at aleksander.es> writes:
> 
>> On Sat, Apr 2, 2016 at 10:13 PM, Bjørn Mork <bjorn at mork.no> wrote:
>>>> How far did you get with that Collin?
>>>
>>> I believe the posted patches were functional, but there were some
>>> outstanding questions on how to properly integrate it in
>>> MM/libmbim/libqmi.  Is that correct, Aleksander?
>>
>> Yes, that's right. Anyway, if someone is up to polishing those patches
>> and integrating them in libmbim sources directly, even if not perfect,
>> I think it would be good not to forget about them. I kind of already
>> forgot about them myself :)
> 
> This isn't really polishing... Rather the contrary ;)
> 
> The attached patch set is a sort of working proof-of-concept.  It needs
> to be cleaned up by someone understanding all the G-stuff :) And it
> should have a lot more error checking.  Testing for EXT_QMUX support
> instead of timing out would be nice for example.  And the library
> integration could be made nicer.  Maybe dynamically loading libmbim from
> libqmi to prevent the hard dependency?
> 
> The libmbim patch is Collin's latest version with only context changes.
> 
> The remaining two libqmi patches provide generic QMI access over MBIM.
> FCC auth is only one possibility.  Many other QMI requests work too:
> 

Here is a somewhat polished version of Colins patch + a patch for mbimcli.
The polish includes some indentation fixes and a new json-parameter in
the codegen stuff to avoid changed behavior for other services using
"unsized-byte-array".

Emil



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-support-for-QMI-over-MBIM-service.patch
Type: text/x-diff
Size: 21610 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libmbim-devel/attachments/20160404/3a2fb316/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Added-command-to-write-FCC-Authentication-with-QMI-o.patch
Type: text/x-diff
Size: 16479 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libmbim-devel/attachments/20160404/3a2fb316/attachment-0003.patch>