[PATCH 1/2] libmbim-glib: add partial support for Basic IP Connectivity Extensions service

[Ben Chan]

On Fri, Jul 27, 2018 at 2:57 AM Aleksander Morgado
<aleksander at aleksander.es> wrote:
>
> On Fri, Jul 27, 2018 at 8:38 AM, Ben Chan <benchan at chromium.org> wrote:
> > ---
>
> LGTM, go on and merge
>
> > +
> > +  // *********************************************************************************
> > +  { "name"     : "MbimPcoValue",
> > +    "type"     : "Struct",
> > +    "contents" : [ { "name"             : "SessionId",
> > +                     "format"           : "guint32" },
> > +                   { "name"             : "PcoDataSize",
> > +                     "format"           : "guint32" },
> > +                   { "name"             : "PcoDataType",
> > +                     "format"           : "guint32",
> > +                     "public-format"    : "MbimPcoType" },
> > +                   { "name"             : "PcoDataBuffer",
> > +                     "format"           : "ref-byte-array",

I made a mistake here. This should be 'ref-byte-array-no-offset',
instead of 'ref-byte-array' as there is no offset field in the struct.
However, I noticed the mbim-codegen currently doesn't handle
'ref-byte-array-no-offset' field in Structs, so I submit another patch
for that:

https://lists.freedesktop.org/archives/libmbim-devel/2018-July/001008.html

> > +                     "array-size-field" : "PcoDataSize" } ] }