[PATCH] add device-open-net cmdline option

[Tim Harvey]

On Fri, Dec 13, 2013 at 12:21 AM, Aleksander Morgado
<aleksander at lanedo.com> wrote:
> Hey Tim!
>
> On 12/12/13 19:40, Tim Harvey wrote:
>> The device-open-net cmdline option allows you to specify network-mode
>> and qos-header mode flags when opening the device.
>>
>> This has been found to be necessary on some cards/modes such as the MC7750
>> in LTE mode.
>>
>> I lack the propper hardware/signal to test this properly - review/testing
>> needed.
>>
>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
>> ---
>
> It looked quite good, but ended up modifying the patch to take a slight
> different approach, which is to parse the input string based on the
> actual nicknames of the QmiDeviceOpenFlags enum type, as done with other
> flag mask values passed in qmicli (even if only 4 flag values are
> expected, but anyway, for consistency). I actually had to add type
> generation for that flag and also for QmiDeviceReleaseClientFlags, which
> where missing in libqmi-glib and was a bug on itself.
>
> Also, the set of flags passed needs to be separated with "|", not with a
> comma, as done for other sets of flags around, so all these are now valid:
>
>  --device-open-net="net-802-3|net-qos-header"
>  --device-open-net="net-802-3|net-no-qos-header"
>  --device-open-net="net-qos-header|net-802-3"
>  --device-open-net="net-no-qos-header|net-802-3"
>  ... and so on
>
> Changes are all in git master now.
>
> Thanks for the good start! :)
>

Aleksander,

No problem - thanks for all your work on this project.  I hope to see
libqmi fully supported in OpenWrt someday soon (as in netifd/uci
integration like the patch you posted earlier this year that never
made it in).

I'm hoping for some feedback on this new feature as I found I did not
need it for MC7750 3G.  I can not get a 4G/LTE connection on my MC7750
(I think its an antenna/radio issue) but I've been told by someone I'm
collaborating with that has the same modem that they needed this patch
for an 4G/LTE connection using libqmi1.6 but did strangely said they
did not need it for libqmi1.8.

Does it make sense that you would need to vary the open flags for 3G
vs 4G?  I am fairly ignorant about how the various protocols work.

Thanks,

Tim