Updates to the QMI username logic

Roshan Pius rpius at google.com
Mon Nov 10 09:00:56 PST 2014


Looks good to me. Do we need to port the same fix to libmbim?

Thanks,
Roshan Pius

On Sun, Nov 9, 2014 at 11:11 AM, Aleksander Morgado <
aleksander at aleksander.es> wrote:

> Hey Roshan,
>
> Could you please review the following patches and tell me what you think?
>
> [PATCH 1/2] build: rename '--enable-qmi-proxy-username'...
> This one is just a rename of the configure option, so that it's more
> generic
> (i.e. not related just to the proxy).
>
>
> [PATCH 2/2] libqmi,utils: new internal __qmi_user_allowed() method
> This one consolidates a new helper method to check if the user is allowed
> or
> not. Please also note that your patch introduced a bug in qmi_proxy_open():
> when the user wasn't allowed you would return FALSE without the GError
> being
> set.
>
> --
> Aleksander
> https://aleksander.es
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libqmi-devel/attachments/20141110/fb75cbae/attachment.html>


More information about the libqmi-devel mailing list