Updates to the QMI username logic

[Aleksander Morgado]

On Mon, Nov 10, 2014 at 6:00 PM, Roshan Pius <rpius at google.com> wrote:
> Looks good to me. Do we need to port the same fix to libmbim?
>

We should, yes, to keep them in sync.

> Thanks,
> Roshan Pius
>
> On Sun, Nov 9, 2014 at 11:11 AM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
>>
>> Hey Roshan,
>>
>> Could you please review the following patches and tell me what you think?
>>
>> [PATCH 1/2] build: rename '--enable-qmi-proxy-username'...
>> This one is just a rename of the configure option, so that it's more
>> generic
>> (i.e. not related just to the proxy).
>>
>>
>> [PATCH 2/2] libqmi,utils: new internal __qmi_user_allowed() method
>> This one consolidates a new helper method to check if the user is allowed
>> or
>> not. Please also note that your patch introduced a bug in
>> qmi_proxy_open():
>> when the user wasn't allowed you would return FALSE without the GError
>> being
>> set.
>>
>> --
>> Aleksander
>> https://aleksander.es
>
>



-- 
Aleksander
https://aleksander.es