qmi-over-mbim branch review

Aleksander Morgado aleksander at aleksander.es
Wed Apr 20 16:45:00 UTC 2016


On Wed, Apr 20, 2016 at 5:12 PM, Dan Williams <dcbw at redhat.com> wrote:
> Looks OK to me (both libqmi and libmbim parts) though of course some of
> the error handling and TID stuff still has to be done.
>

Yeah, I saw that as well.

> Also, device_open_context_step() should probably return an error if
> !MBIM_QMUX and the user passes QMI_DEVICE_OPEN_FLAGS_MBIM.  Otherwise
> clients would have no indication that the libqmi they are working with
> doesn't have MBIM support, right?

Yep.

I'm wondering whether this should be something that it's worth getting
into MM 1.6. There seems to be a lot of people with this exact same
issue lately... what do you think?

-- 
Aleksander
https://aleksander.es


More information about the libqmi-devel mailing list