qmi-over-mbim branch review

Dan Williams dcbw at redhat.com
Wed Apr 20 17:24:49 UTC 2016


On Wed, 2016-04-20 at 18:45 +0200, Aleksander Morgado wrote:
> On Wed, Apr 20, 2016 at 5:12 PM, Dan Williams <dcbw at redhat.com>
> wrote:
> > 
> > Looks OK to me (both libqmi and libmbim parts) though of course
> > some of
> > the error handling and TID stuff still has to be done.
> > 
> Yeah, I saw that as well.
> 
> > 
> > Also, device_open_context_step() should probably return an error if
> > !MBIM_QMUX and the user passes
> > QMI_DEVICE_OPEN_FLAGS_MBIM.  Otherwise
> > clients would have no indication that the libqmi they are working
> > with
> > doesn't have MBIM support, right?
> Yep.
> 
> I'm wondering whether this should be something that it's worth
> getting
> into MM 1.6. There seems to be a lot of people with this exact same
> issue lately... what do you think?

Yes, I think it's worth delaying 1.6 for this.

Dan


More information about the libqmi-devel mailing list