MC7430 modem issue

[dailijin]

Hi Bjorn,


I have no environment now, need customer to do this test.
I have modified usbnet like below:
void usbnet_skb_return (struct usbnet *dev, struct sk_buff *skb)
{
    int status;


    if (test_bit(EVENT_RX_PAUSED, &dev->flags)) {
        skb_queue_tail(&dev->rxq_pause, skb);
        return;
    }    
    if (skb->protocol != 8)
        skb->protocol = eth_type_trans (skb, dev->net);


    dev->net->stats.rx_packets++;
    dev->net->stats.rx_bytes += skb->len;


    netif_dbg(dev, rx_status, dev->net, "< rx, len %zu, type 0x%x\n",
          skb->len + sizeof (struct ethhdr), skb->protocol);
    memset (skb->cb, 0, sizeof (struct skb_data));


    if (skb_defer_rx_timestamp(skb))
        return;


    status = netif_rx (skb);
    if (status != NET_RX_SUCCESS)
        netif_dbg(dev, rx_err, dev->net,
              "netif_rx status %d\n", status);
}


this can make MC7430 not enter into this logic, and for other modems, the logic is same as original.


I am not sure whether this is right? still wait customer's fedback.



--

Best Regards,
Dai,Lijin



At 2016-04-27 15:54:23, "Bjørn Mork" <bjorn at mork.no> wrote:
>dailijin  <dailijin126 at 126.com> writes:
>
>> For support MC7430, I have refered to
>> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/drivers/net/usb/usbnet.c?id=81e0ce79f2919dbd5f025894d29aa806af8695c7
>> to modify usbnet driver, this will cause my system periodically reboot
>> when plugin ATT Beam modem or Sprint modem which use GobiNet
>> driver. seems there are conflict.  Do you know how to fix this issue?
>
>Ouch.  I wonder if you can test the attached patch, which also tries to
>capture a warning if it ever hits.  Which it really shouldn't...  But I
>don't see any other way that patch could cause such problems. Please let
>me know how this goes.  If you get a warning then I hope that will
>explain what happens here.
>
>
>Bjørn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libqmi-devel/attachments/20160427/5f1737f2/attachment.html>